Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting executable bits on three files in sandbox Fix/798 #823

Merged
merged 2 commits into from
Feb 22, 2015
Merged

Setting executable bits on three files in sandbox Fix/798 #823

merged 2 commits into from
Feb 22, 2015

Conversation

alameldin
Copy link
Contributor

“fixes issue #798 ”

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@ctb
Copy link
Member

ctb commented Feb 22, 2015

ok to test

@alameldin
Copy link
Contributor Author

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Member

ctb commented Feb 22, 2015

Looks good; merging. Thank you!

ctb added a commit that referenced this pull request Feb 22, 2015
@ctb
Merge pull request #823 from alameldin/fix/798
93f5c47 
Setting executable bits on three files in sandbox Fix/798
@ctb ctb merged commit 93f5c47 into dib-lab:master Feb 22, 2015
@ctb ctb mentioned this pull request Feb 22, 2015
Closed
mr-c
mr-c reviewed Feb 23, 2015
View reviewed changes
ChangeLog
@@ -1,3 +1,7 @@
2015-02-21 Hussien Alameldin <hussien@msu.edu>

* sandbox/calc-best-assembly.py, collect-variants.py, graph-size.py: Set executable bits using "chmod +x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is over 80 characters long. @ctb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mr-c should i edit it?

@mr-c mr-c mentioned this pull request Feb 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alameldin @ged-jenkins @ctb @mr-c