Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around versioneer bug #835

Merged
merged 1 commit into from
Feb 23, 2015
Merged

work around versioneer bug #835

merged 1 commit into from
Feb 23, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Feb 23, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@mr-c
Copy link
Contributor Author

mr-c commented Feb 23, 2015

@luizirber Please review and merge; thanks!

@mr-c
Copy link
Contributor Author

mr-c commented Feb 23, 2015

Will fix #829

luizirber added a commit that referenced this pull request Feb 23, 2015
@luizirber luizirber merged commit 802abfe into master Feb 23, 2015
@luizirber luizirber deleted the fix/versioneer-workaround branch February 23, 2015 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants