Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming the sandbox/ scripts to be lowercase #850

Merged
merged 3 commits into from
Feb 28, 2015
Merged

Conversation

alameldin
Copy link
Contributor

fixes issue #846

@alameldin
Copy link
Contributor Author

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@alameldin
Copy link
Contributor Author

ready to review

2015-02-25 Hussien Alameldin <hussien@msu.edu>

* sandbox/bloom_count.py: renamed to bloom-count.py
* sandbox/bloom_count.pyc: renamed to bloom-count.pyc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .pyc files are not actually committed in github so you should remove them from the ChangeLog entry.

@ctb
Copy link
Member

ctb commented Feb 25, 2015

Hah, actually, the goal of the #846 was to change the list of requirements for sandbox files in the docs, not necessarily to change anything in sandbox/. But I don't dislike this set of changes as long as @mr-c agrees.

Main thing TODO - can you edit sandbox/README.rst to reference the new names, and mention that they've been renamed? Something like

  • bloom-count-intersection.py: some description. Renamed from bloom_count_intersection.py in commit f2235bf.

@mr-c
Copy link
Contributor

mr-c commented Feb 25, 2015

@mr-c is sitting next to @alameldin and approves of the name changes

@ctb
Copy link
Member

ctb commented Feb 25, 2015

On Wed, Feb 25, 2015 at 02:01:35PM -0800, Michael R. Crusoe wrote:

@mr-c is sitting next to @alameldin and approves of the name changes

ok, please update README.rst and remove .pyc files from ChangeLog, and
we're good!

@ctb ctb mentioned this pull request Feb 26, 2015
@ctb
Copy link
Member

ctb commented Feb 26, 2015

LGTM. Make it mergeable, please!

@ctb
Copy link
Member

ctb commented Feb 28, 2015

Thanks!

ctb added a commit that referenced this pull request Feb 28, 2015
renaming the sandbox/ scripts to be lowercase
@ctb ctb merged commit 414b4e8 into dib-lab:master Feb 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants