-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renaming the sandbox/ scripts to be lowercase #850
Conversation
|
ready to review |
2015-02-25 Hussien Alameldin <hussien@msu.edu> | ||
|
||
* sandbox/bloom_count.py: renamed to bloom-count.py | ||
* sandbox/bloom_count.pyc: renamed to bloom-count.pyc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the .pyc files are not actually committed in github so you should remove them from the ChangeLog entry.
Hah, actually, the goal of the #846 was to change the list of requirements for sandbox files in the docs, not necessarily to change anything in sandbox/. But I don't dislike this set of changes as long as @mr-c agrees. Main thing TODO - can you edit sandbox/README.rst to reference the new names, and mention that they've been renamed? Something like
|
@mr-c is sitting next to @alameldin and approves of the name changes |
On Wed, Feb 25, 2015 at 02:01:35PM -0800, Michael R. Crusoe wrote:
ok, please update README.rst and remove .pyc files from ChangeLog, and |
LGTM. Make it mergeable, please! |
Thanks! |
renaming the sandbox/ scripts to be lowercase
fixes issue #846