Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sandbox scripts for kfile changes #851

Merged
merged 5 commits into from
Mar 6, 2015
Merged

fix sandbox scripts for kfile changes #851

merged 5 commits into from
Mar 6, 2015

Conversation

ctb
Copy link
Member

@ctb ctb commented Feb 25, 2015

ref #849, this PR fixes a few sandbox scripts that are (a) run in khmer-recipes and (b) use the khmer.kfile functionality.

@ctb
Copy link
Member Author

ctb commented Feb 25, 2015

  • Is it mergable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage.
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Member Author

ctb commented Feb 25, 2015

Ready for review. Note: pre-existing sandbox scripts only; be gentle.

@mr-c
Copy link
Contributor

mr-c commented Mar 5, 2015

LGTM

@@ -1,3 +1,8 @@
2015-02-25 Titus Brown <titus@idyll.org>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update date to be same day or newer than the entry below.

Copy link
Member Author

@ctb ctb Mar 6, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mr-c added a commit that referenced this pull request Mar 6, 2015
fix sandbox scripts for kfile changes
@mr-c mr-c merged commit 9970094 into master Mar 6, 2015
@mr-c mr-c deleted the fix/sandbox_scripts branch March 6, 2015 16:42
@mr-c
Copy link
Contributor

mr-c commented Mar 6, 2015

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants