check for errors while writing to disk #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mr-c
force-pushed
the
fix/write_exceptions
branch
from
014021c to
817192b
Compare
|
This PR lowers coverage due to extra IO error checking code and how hard it is to test that. |
|
Jenkins, please retest this |
mr-c
force-pushed
the
fix/write_exceptions
branch
from
3c0062d to
4124cfc
Compare
|
@luizirber @camillescott @ctb ready for review and merge |
mr-c
force-pushed
the
fix/write_exceptions
branch
from
4124cfc to
fd93397
Compare
| ksize, = unpack('I', countinghash.read(uint_size)) | ||
| n_tables, = unpack('B', countinghash.read(1)) | ||
| table_size, = unpack('Q', countinghash.read(ulonglong_size)) | ||
| except: |
There was a problem hiding this comment.
Can this check be used on extract_hashbits_info too?
(at first I thought this could be more strict and catch only struct.error, but there might be IOError too and in the end they are all a kind of corrupted input, so I think that's fine)
There was a problem hiding this comment.
Done, thanks for the suggestion.
|
It would be good to open an issue to add tests for these extra IO error checking code (per #856 (comment) ) |
mr-c
force-pushed
the
fix/write_exceptions
branch
from
fd93397 to
3881bad
Compare
|
Jenkins, retest this please |
mr-c
force-pushed
the
fix/write_exceptions
branch
from
3881bad to
1c7b728
Compare
luizirber
added a commit
that referenced
this pull request
Apr 14, 2015
check for errors while writing to disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #443