Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add n_tables accessor to Hashbits #880

Merged
merged 2 commits into from
Mar 30, 2015
Merged

Add n_tables accessor to Hashbits #880

merged 2 commits into from
Mar 30, 2015

Conversation

kdm9
Copy link
Contributor

@kdm9 kdm9 commented Mar 23, 2015

Companion to #879

This adds khmer::Hashbits::n_tables() as a convenience method.

kdm9 added a commit that referenced this pull request Mar 23, 2015
@kdm9
Copy link
Contributor Author

kdm9 commented Mar 23, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@kdm9
Copy link
Contributor Author

kdm9 commented Mar 23, 2015

@mr-c: Any desire for these to appear in python-land? I could add that to this PR

@kdm9
Copy link
Contributor Author

kdm9 commented Mar 24, 2015

retest this please

@kdm9 kdm9 force-pushed the feat/hashbits-ntables branch from 12ce770 to 74bb637 Compare March 28, 2015 12:06
@mr-c
Copy link
Contributor

mr-c commented Mar 30, 2015

@kdmurray91 Naw, another day. Thanks!

mr-c added a commit that referenced this pull request Mar 30, 2015
@mr-c mr-c merged commit 9f4ccb1 into master Mar 30, 2015
@mr-c mr-c deleted the feat/hashbits-ntables branch March 30, 2015 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants