Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make doc gen repro #886

Merged
merged 1 commit into from
Apr 1, 2015
Merged

make doc gen repro #886

merged 1 commit into from
Apr 1, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Mar 30, 2015

No description provided.

@mr-c
Copy link
Contributor Author

mr-c commented Mar 30, 2015

Jenkins, retest this please

@mr-c
Copy link
Contributor Author

mr-c commented Mar 30, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@mr-c mr-c force-pushed the fix/repro branch 2 times, most recently from d535f80 to 5e9d600 Compare March 30, 2015 14:00
@mr-c
Copy link
Contributor Author

mr-c commented Mar 30, 2015

@camillescott @luizirber @ctb Ready for review and merge

@luizirber
Copy link
Member

LGTM, just need to fix Changelog for merging.

mr-c added a commit that referenced this pull request Apr 1, 2015
@mr-c
Merge pull request #886 from ged-lab/fix/repro
55e3684 
make doc gen repro
@mr-c mr-c merged commit 55e3684 into master Apr 1, 2015
@mr-c
Copy link
Contributor Author

mr-c commented Apr 1, 2015

Thank you @luizirber

@mr-c mr-c deleted the fix/repro branch April 1, 2015 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr-c @luizirber