Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add thread safety to CountingHash::abundance_distribtion #900

Merged
merged 3 commits into from
Apr 14, 2015
Merged

add thread safety to CountingHash::abundance_distribtion #900

merged 3 commits into from
Apr 14, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Apr 3, 2015

Fixes #75

@mr-c
Copy link
Contributor Author

mr-c commented Apr 3, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@mr-c
Copy link
Contributor Author

mr-c commented Apr 3, 2015

@camillescott @luizirber @ctb Ready for review and Merge

@mr-c mr-c force-pushed the fix/abund_dist_threadsafe branch from 62605fc to 00fda8e Compare April 4, 2015 16:14
@mr-c mr-c mentioned this pull request Apr 4, 2015
Closed
6 tasks
@mr-c mr-c force-pushed the fix/abund_dist_threadsafe branch 2 times, most recently from 415a13f to 72064ab Compare April 14, 2015 13:33
@luizirber
Copy link
Member

👍

@mr-c
Copy link
Contributor Author

mr-c commented Apr 14, 2015

Jenkins, test this please

luizirber added a commit that referenced this pull request Apr 14, 2015
@luizirber
Merge pull request #900 from ged-lab/fix/abund_dist_threadsafe
bca8fd1 
add thread safety to CountingHash::abundance_distribtion
@luizirber luizirber merged commit bca8fd1 into master Apr 14, 2015
@luizirber luizirber deleted the fix/abund_dist_threadsafe branch April 14, 2015 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

abundance-dist-single.py fails with small files and many threads
2 participants
@mr-c @luizirber