Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split test for extract_long_sequences into test for fa and for fq #901

Merged
merged 4 commits into from
Apr 17, 2015

Conversation

jessicalumian
Copy link

splitting test_extract_long_sequences into 2 tests specific to fasta and fastq formats as described in issue #825

@jessicalumian
Copy link
Author

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@jessicalumian
Copy link
Author

can I get two pairs of eyes to look over this? @b-wyss @bocajnotnef @brtaylor92 @wrightmhw

@SensibleSalmon
Copy link
Contributor

LGTM, minus the merge conflict; do a git pull [whichever remote gedlab is] master and watch for the conflict.

@jessicalumian jessicalumian merged commit 02c2184 into master Apr 17, 2015
@ctb
Copy link
Member

ctb commented Apr 19, 2015

Uhh, should this have been merged, @mr-c?

@SensibleSalmon
Copy link
Contributor

Technically no, but the end result of the CR was that it should be merged.
(I attempted to revert, then attempted to revert my revert and I'm not
totally certain where that landed. @mr-c said he would sort it out the next
time he was on the ground.)

On Sat, Apr 18, 2015, 20:28 C. Titus Brown notifications@github.com wrote:

Uhh, should this have been merged, @mr-c https://github.com/mr-c?


Reply to this email directly or view it on GitHub
#901 (comment).

@ctb
Copy link
Member

ctb commented Apr 19, 2015

OK. I see fragmented versions of that conversation on slack, too; in the future, let's please document in the issue/PR itself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants