Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly test installed khmer module post install #911

Merged
merged 2 commits into from
Apr 15, 2015

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Apr 5, 2015

No description provided.

@mr-c mr-c force-pushed the adjust-release-checklist branch from 2a538c5 to 07d1f1b Compare April 15, 2015 14:59
@mr-c
Copy link
Contributor Author

mr-c commented Apr 15, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@luizirber Please review & merge :-)

luizirber added a commit that referenced this pull request Apr 15, 2015
Properly test installed khmer module post install
@luizirber luizirber merged commit 192ae79 into master Apr 15, 2015
@luizirber luizirber deleted the adjust-release-checklist branch April 15, 2015 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants