Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #21: Refactor Hash Size Warning Logic into Common Module #944

Merged
merged 6 commits into from
Apr 14, 2015

Conversation

susinmotion
Copy link
Contributor

fis issue #21
pull out error handling for too many collisions (table too small) into.init_.

Update tests to accommodate.

In filter abund, no threshold for max collisions listed--defaults to .2
Default is force=False. Force allowed in all places.

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@ctb
Copy link
Member

ctb commented Apr 14, 2015 via email

@mr-c
Copy link
Contributor

mr-c commented Apr 14, 2015

Jenkins, ok to test

@mr-c
Copy link
Contributor

mr-c commented Apr 14, 2015

Jenkins, test this please

mr-c added a commit that referenced this pull request Apr 14, 2015
Fix issue #21:  Refactor Hash Size Warning Logic into Common Module
@mr-c mr-c merged commit 32aaad6 into dib-lab:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants