Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/777 #952

Merged
merged 13 commits into from
Apr 16, 2015
Merged

Fix/777 #952

merged 13 commits into from
Apr 16, 2015

Conversation

elmbeech
Copy link
Contributor

At doc/dev/getting-started.rst I added information for OS X mac port distro users.

@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@elmbeech
Copy link
Contributor Author

At doc/dev/getting-started.rst I added information for OS X homebrew distro users.

@elmbeech elmbeech closed this Apr 14, 2015
@elmbeech elmbeech reopened this Apr 14, 2015
@ged-jenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@ged-jenkins
Copy link

Can one of the admins verify this patch?

@mr-c
Copy link
Contributor

mr-c commented Apr 14, 2015

Jenkins, add to test list

@mr-c
Copy link
Contributor

mr-c commented Apr 14, 2015

Jenkins, ok to test

`Conda <https://github.com/conda/conda>`__ users on any platform
should instead create a separate Conda environment::

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra tab?

@elmbeech
Copy link
Contributor Author

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@elmbeech
Copy link
Contributor Author

There is no copyright notification in the getting-started.rst file.
Should I add one?

@mr-c
Copy link
Contributor

mr-c commented Apr 15, 2015

+1 to copyright header being added; good catch!

@elmbeech
Copy link
Contributor Author

@ mr-c: shoud I add a copy right header to getting-started.rst or do you prefer to add copyright headers to all the rst files at the same time?

@mr-c
Copy link
Contributor

mr-c commented Apr 15, 2015

For the purposes of this pull request lets keep it to just this file. We can open an issue for the other files.

@elmbeech
Copy link
Contributor Author

hi Mikael, this bugfix branch should now be ready to get merged with ged master.

mr-c added a commit that referenced this pull request Apr 16, 2015
@mr-c mr-c merged commit 8a13620 into dib-lab:master Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants