Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total number of reads to summary json/tsv #996

Merged
merged 3 commits into from
May 13, 2015

Conversation

kdm9
Copy link
Contributor

@kdm9 kdm9 commented May 12, 2015

This PR adds a count of the total number of reads to the machine readable outputs of load-into-counting.py (TSV/JSONs).

It takes the sum of the number of reads processed from the khmer.ReadParser object which is used for hashing across all read files.

I've also bumped the "mrinfo_version" tag in the json output to 0.2.0, FWIW.

Cheers,
K

kdm9 added a commit that referenced this pull request May 12, 2015
kdm9 added a commit that referenced this pull request May 12, 2015
@kdm9
Copy link
Contributor Author

kdm9 commented May 12, 2015

Also apologies if jenkins or others complain about a commit to master, I accidentally changed to master between the above commits, and pushed the change. I've reverted it.

@kdm9
Copy link
Contributor Author

kdm9 commented May 12, 2015

jenkins retest this please

kdm9 added a commit that referenced this pull request May 12, 2015
@kdm9
Copy link
Contributor Author

kdm9 commented May 12, 2015

Ah yes, one of these things:

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@kdm9 kdm9 force-pushed the feat/n_reads_summary_lic.py branch from 189a890 to a432d83 Compare May 13, 2015 06:04
@kdm9
Copy link
Contributor Author

kdm9 commented May 13, 2015

Made mergable after change to master, ready for review @mr-c @ctb et al 😄

(P.S., I see you all pinging each other to say a PR is ready for review, is this what you'd like external contributors like myself to do too?)

@mr-c
Copy link
Contributor

mr-c commented May 13, 2015

@kdmurray91 LGTM! Yes, please continue to @ mention us when you are ready for review. The full list is at http://khmer.readthedocs.org/en/latest/dev/getting-started.html#claiming-an-issue-and-starting-to-develop item number 12 (this was formalized during the coding sprint at PyCon).

mr-c added a commit that referenced this pull request May 13, 2015
Add total number of reads to summary json/tsv
@mr-c mr-c merged commit db756d0 into master May 13, 2015
@mr-c mr-c deleted the feat/n_reads_summary_lic.py branch May 13, 2015 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants