Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests & constrain behavior in various ways. #54

Merged
merged 12 commits into from
Dec 20, 2016
Merged

Conversation

ctb
Copy link
Member

@ctb ctb commented Dec 19, 2016

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality, is it tested?
  • make format diff_pylint_report doc Is it well formatted?
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb
Copy link
Member Author

ctb commented Dec 19, 2016

Fixes dib-lab/khmer#1468

@codecov-io
Copy link

codecov-io commented Dec 20, 2016

Current coverage is 80.50% (diff: 100%)

No coverage report found for master at 6ad556b.

Powered by Codecov. Last update 6ad556b...fb63bc7

@ctb
Copy link
Member Author

ctb commented Dec 20, 2016

Should be ready for review @standage @luizirber

Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luizirber luizirber merged commit 3bc817c into master Dec 20, 2016
@luizirber luizirber deleted the update_misc branch December 20, 2016 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants