Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Expose Contract Data #195

Merged
merged 1 commit into from
May 16, 2023
Merged

FIX: Expose Contract Data #195

merged 1 commit into from
May 16, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented May 16, 2023 •
edited
Loading

This PR intent show contract data.

Problem reported by @josediegorobles.

PS: To obtain the balance, it is necessary to create the watcher for the user, using the watcher_pub field.

cryptoquick
cryptoquick approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. This solution for reading contract fields is a little unwieldy. I'm wondering what @dr_orlovsky thinks. This works for now, though.

@crisdut
Copy link
Member Author

crisdut commented May 16, 2023

Interesting. This solution for reading contract fields is a little unwieldy. I'm wondering what @dr_orlovsky thinks. This works for now, though.

I thought the same when I saw it for the first time, the new version is easier to navigate through the data, I'm testing it now.

josediegorobles
josediegorobles approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@josediegorobles josediegorobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josediegorobles josediegorobles merged commit e99c0ff into development May 16, 2023
@josediegorobles josediegorobles deleted the CD/fix-contract-data branch May 16, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoquick cryptoquick cryptoquick approved these changes

@josediegorobles josediegorobles josediegorobles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisdut @cryptoquick @josediegorobles