Code coverage nces and clip

[Jean-KOUAGOU]

I have added tests for NCES and CLIP. Other major changes include:

1. Improving NCES benchmarking results by enabling repetitions in example sampling and setting num_predictions to 100 instead of the previous 5
2. NCES fit method is now faster as I now use np.random.choice instead of the old implementation with list comprehension
3. Added benchmarking results for CLIP
4. Updated the documentation accordingly
5. Updated both NCES and CLIP notebooks in examples folder, and removed unecessary/redundant NCES notebooks

[Demirrr]

@alkidbaci Could you review it please ?

[alkidbaci]

I integrated the coverage computation on the workflow so we can always see the coverage report after each push. If you check the action run of the latest commit: https://github.com/dice-group/Ontolearn/actions/runs/9776699022/job/26989784731?pr=419 , you can find the report under "Coverage report".

The overall coverage percentage has gone up indeed but there are still some NCES and CLIP modules that have very low coverage:

Name                                       Stmts   Miss  Cover   Missing
------------------------------------------------------------------------
ontolearn/clip_trainer.py                    120    101    16%   45-50, 53-55, 58-65, 69-75, 78-161
ontolearn/nces_trainer.py                    173    142    18%   56-62, 66-93, 96-103, 107-113, 116-134, 137, 140-225

If you can create some test cases for those modules, it would be great @Jean-KOUAGOU.

[Jean-KOUAGOU]

Ok, I will do

…

On Wed, 3 Jul 2024, 13:35 Alkid Baci, ***@***.***> wrote: I integrated the coverage computation on the workflow so we can always see the coverage report after each push. If you check the action run of the latest commit: https://github.com/dice-group/Ontolearn/actions/runs/9776699022/job/26989784731?pr=419 , you can find the report under "Coverage report". The overall coverage percentage has gone up indeed but there are still some NCES and CLIP modules that have very low coverage: Name Stmts Miss Cover Missing ------------------------------------------------------------------------ ontolearn/clip_trainer.py 120 101 16% 45-50, 53-55, 58-65, 69-75, 78-161 ontolearn/nces_trainer.py 173 142 18% 56-62, 66-93, 96-103, 107-113, 116-134, 137, 140-225 If you can create some test cases for those modules, it would be great @Jean-KOUAGOU <https://github.com/Jean-KOUAGOU>. — Reply to this email directly, view it on GitHub <#419 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK4X4EVVPRSJIGDWFLPYBN3ZKPOZZAVCNFSM6AAAAABKH5HLCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVHA3DQNRYGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>