Fixes

dice-group · Oct 31, 2024 · 297f8d9 · 297f8d9
1 parent a9ccaac
commit 297f8d9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/docs/usage/reasoner.md b/docs/usage/reasoner.md
@@ -15,7 +15,7 @@ onto = manager.load_ontology(IRI.create("KGs/Family/father.owl"))
 In our Owlapy library, we provide two main reasoner classes:
 
 
-- [**StructuralReasoner**](owlapy.owl_reasoner.FastInstanceCheckerReasoner) (What used to be FastInstanceCheckerReasoner )
+- [**StructuralReasoner**](owlapy.owl_reasoner.StructuralReasoner) (What used to be FastInstanceCheckerReasoner )
 
     Structural Reasoner is the base reasoner in Owlapy. This reasoner works 
    under CWA/PCWA and the base library used for it is _owlready2_. The functionalities

diff --git a/owlapy/owl_reasoner.py b/owlapy/owl_reasoner.py
@@ -76,7 +76,7 @@ def __init__(self, ontology: AbstractOWLOntology, *, class_cache: bool = True,
             property_cache: Whether to cache property values.
             negation_default: Whether to assume a missing fact means it is false ("closed world view").
             sub_properties: Whether to take sub properties into account for the
-                :func:`OWLReasoner_FastInstanceChecker.instances` retrieval.
+                :func:`StructuralReasoner.instances` retrieval.
             """
         super().__init__(ontology)
         assert isinstance(ontology, Ontology)
@@ -692,7 +692,7 @@ def _find_some_values(self, pe: OWLObjectPropertyExpression, filler_inds: Set[OW
                           min_count: int = 1, max_count: Optional[int] = None) -> FrozenSet[OWLNamedIndividual]:
         """Get all individuals that have one of filler_inds as their object property value."""
         ret = set()
-        if self._ontology.is_modified:
+        if self._ontology.is_modified and (self.class_cache or self._property_cache):
             self.reset_and_disable_cache()
         if self._property_cache:
             self._lazy_cache_obj_prop(pe)
@@ -764,7 +764,7 @@ def _find_instances(self, ce: OWLClassExpression) -> FrozenSet[OWLNamedIndividua
 
     @_find_instances.register
     def _(self, c: OWLClass) -> FrozenSet[OWLNamedIndividual]:
-        if self._ontology.is_modified:
+        if self._ontology.is_modified and (self.class_cache or self._property_cache):
             self.reset_and_disable_cache()
         if self.class_cache:
             self._lazy_cache_class(c)
@@ -883,7 +883,7 @@ def _(self, ce: OWLDataSomeValuesFrom) -> FrozenSet[OWLNamedIndividual]:
         filler = ce.get_filler()
         assert isinstance(pe, OWLDataProperty)
 
-        if self._ontology.is_modified:
+        if self._ontology.is_modified and (self.class_cache or self._property_cache):
             self.reset_and_disable_cache()
         property_cache = self._property_cache
 

diff --git a/tests/test_owlapy_structural_reasoner.py b/tests/test_owlapy_structural_reasoner.py
@@ -306,6 +306,12 @@ def test_sub_property_inclusion(self):
 
         # sub_property = True
         reasoner = StructuralReasoner(onto, sub_properties=True)
+        reasoner._ontology.is_modified = False  # This is done because, for sub_properties to work as expected it needs
+                                                # _property_cache of the reasoner to be True which would normally be
+                                                # False when the ontology is modified. Info: Cache needs to be reset and
+                                                # disabled when ontolgy modification is detected because the
+                                                # cached facts may not hold anymore. Hence, setting is_modified to False
+                                                # is an excepton to check this test.
 
         # object property
         ce = OWLObjectIntersectionOf([compound, OWLObjectSomeValuesFrom(super_has_structure, benzene)])