Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring suggestions #11

Closed
alkidbaci opened this issue Apr 2, 2024 · 1 comment
Closed

Refactoring suggestions #11

alkidbaci opened this issue Apr 2, 2024 · 1 comment
Assignees

Comments

@alkidbaci
Copy link
Collaborator

alkidbaci commented Apr 2, 2024

Counter-intuitive issues with the current structure:

  1. All owl objects are located in owlapy/model/init.py.
  2. Conversion methods are scattered in 3 files render.py, parser.py and owl2sparql/converter.py.

Proposed solution:

  1. Group owl objects by semantic meaning in different modules. Import all in owlapy/__init__.py
  2. Relocate converter.py in the owlapy directory, import conversion methods in owlapy/__init__.py.
@alkidbaci alkidbaci added enhancement New feature or request and removed enhancement New feature or request labels Apr 2, 2024
@alkidbaci alkidbaci self-assigned this Apr 2, 2024
@Demirrr
Copy link
Member

Demirrr commented Apr 9, 2024

The first phase of the refactoring is done with #21. Please continue on the second phase defined by the following todos

  • Instead of using from owlapy.model import ... we use explicit imports, e.g. from owlapy.owl_class_expression import ..
  • Move the reamining class definitions (e.g. OWLOntologyID, .., OWLReasoner into a suitably named python script under owlapy
  • Continue refactoring until owlapy/model can be removed.

In the third phase, we will create modules under owlapy to group individual scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants