Refactoring, documentation and more #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demirrr
approved these changes
Apr 17, 2024
owlapy/__init__.py
Outdated
There was a problem hiding this comment.
Please increment the version version = '0.2'
There was a problem hiding this comment.
Sure, but didn't we say 1.0.0?
| __slots__ = '_operands' | ||
| type_index: Final = 4005 | ||
| type_index: Final = 4004 |
There was a problem hiding this comment.
Do you know the meaning of the type index 4005 and why it has been incremented
There was a problem hiding this comment.
I think its an index to track the order of the owl entities but this is a bit strange because I don't remember changing its value
|
Should I proceed with the new release @Demirrr ? |
|
Yes please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed task 2 and 3 mentioned on the second comment on issue Refactoring suggestions #11
owlapy.modelis disbandedowlapy.owl2sparqlis also removed,converter.pymoved directly underowlapyFulfilled point 2 and 3 mentioned on issue Using inheritance #15 for the reset of the classes.
get_iri()is now completely removedirito get the iri,strto all classes which have an iri.Updated documentation
README.mdin accordanceMade some fixes here and there