OWL2SPARQL Converter ForAll Alternative

[nkaralis]

Introduces an alternative for the ForAll mapping based on De Morgan's laws.

NOTE: The interface (arguments) of the converter have changed. Might break some stuff in Ontolearn

[Demirrr]

@alkidbaci Could you review it today if you have time ?

[alkidbaci]

Sure thing

[alkidbaci]

@nkaralis I noticed that you have commented outline 128-129 and added line 274-277 instead. The class argument named_individuals was applicable for every conversion but according to your changes, now its applicable only for concepts of type OWLObjectComplementOf.

One more thing to notice here is that we cannot specify the argument for_all_de_morgan in the method owl_expression_to_sparql but since that argument is only relevant to concepts of type OWLObjectAllValuesFrom maybe it's better to keep it this way. If someone wants to specify a different value for for_all_de_morgan they can create a new instance of Owl2SparqlConverter and call as_query from there.

Other than these, it looks fine to me.

[nkaralis]

Thanks for reviewing the PR.

Regarding the first point, the idea here is that OWLObjectComplementOf iterates over all entities of the graph, whereas other expressions are restricted based on a type.
We could also remove the comments and have both.

Regarding the second point, we could add an extra argument de_morgan_for_all: bool = True. What do you think?

[alkidbaci]

Regarding the first point, the idea here is that OWLObjectComplementOf iterates over all entities of the graph, whereas other expressions are restricted based on a type.

Well, that's a fair point. We can leave it like that then.

Regarding the second point, we could add an extra argument de_morgan_for_all: bool = True. What do you think?

Now that I think again about this, people will get used to using the owl_expression_to_sparql method and that's also the way we recommend in the documentation on how to convert owl to sparql... so I suggest adding that argument. Hope you don't mind doing that.

Thanks for the PR!