Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ontology manipulation #42

Merged
merged 12 commits into from
May 27, 2024
Merged

Ontology manipulation #42

merged 12 commits into from
May 27, 2024

Conversation

alkidbaci
Copy link
Collaborator

@alkidbaci alkidbaci commented May 21, 2024

Added classes for ontology manipulation

  • Ontology representation: added OWLOntology_Owlready2 at owl_ontology.py
  • Ontology manager: added OWLOntologyManager_Owlready2 at owl_ontology_manager.py
  • Ontology reasoning: added OWLReasoner_Owlready2, OWLReasoner_FastInstanceChecker (FIC), OWLReasoner_Owlready2_ComplexCEInstances (CCEI) at owl_reasoner.py

Added more examples

  • added ontology_modification.py
  • added ontology_reasoning.py

Added the rest of owlapy test cases (moved from Ontolearn)

Added KGs download in the workflow

Updated documentation

@Demirrr Demirrr self-requested a review May 24, 2024 07:19
Copy link
Member

@Demirrr Demirrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please remove the postfixes reffering to Owlready2? @alkidbaci

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename OWLOntologyManager_Owlready2 as OWLOntologyManager or a like by removing the postfix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the Owlready2 postfixes?

from owlapy.owl_property import OWLDataProperty, OWLObjectProperty
from owlapy.owl_reasoner import OWLReasoner_Owlready2, OWLReasoner_Owlready2_ComplexCEInstances, BaseReasoner_Owlready2

@alkidbaci
Copy link
Collaborator Author

alkidbaci commented May 24, 2024

Renamed the following classes:

  • OWLOntology_Owlready2Ontogloy
  • OWLOntologyManager_Owlready2OntologyManager
  • OWLReasoner_Owlready2OntologyReasoner
  • OWLReasoner_FastInstanceCheckerFastInstanceCheckerReasoner
  • OWLReasoner_Owlready2_ComplexCEInstancesSyncReasoner
  • BaseReasoner_Owlready2BaseReasoner

PS: Could not rename them to OWLOntology or OWLOntologyManager for example, because it conflicts with the super class name.

@Demirrr Demirrr merged commit c337a9d into develop May 27, 2024
3 checks passed
@Demirrr Demirrr deleted the ontology_manipulation branch May 27, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants