Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring owlapi adaptor #49

Merged
merged 9 commits into from
Jul 12, 2024
Merged

Refactoring owlapi adaptor #49

merged 9 commits into from
Jul 12, 2024

Conversation

alkidbaci
Copy link
Collaborator

@alkidbaci alkidbaci commented Jul 12, 2024

  • Fixed bug where JVM was never shutting down because of an always false check.
  • Removed __enter__ and __exit__ methods from OWLAPIAdaptor because that structure does not allow for creation of new instance of OWLAPIAdaptor. That is because if the JVM is stopped then you cannot restart it ( this is a limitation of JPype)
  • Currently when initializing an object of OWLAPIAdaptor the JVM is started automatically (this is required to perform the successful initialization of the object, therefore the option to manually start the JVM is not possible)
  • New method: To stop the JVM the user can use the method OWLAPIAdaptor.stopJVM(). This method can be called when the user is finished with using its adaptor objects.
  • Updated examples and documentation in accordance
  • Version update for the new release

@alkidbaci alkidbaci requested a review from Demirrr July 12, 2024 13:07
@Demirrr Demirrr merged commit a8c758f into develop Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants