Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tcp sockets #1

Merged
merged 12 commits into from
Dec 5, 2023
Merged

Tcp sockets #1

merged 12 commits into from
Dec 5, 2023

Conversation

badeend
Copy link

@badeend badeend commented Dec 3, 2023 •
edited
Loading

  • Added support for all TCP operations & socket options.
  • Added UDP stubs

Notable remaining TODOs:

  • update to 2023-11-10 snapshot
  • send&recv flags
  • implement sendto, sendmsg, sendmmsg, recvfrom, recvmsg, recvmmsg

dicej
dicej reviewed Dec 4, 2023
View reviewed changes
Copy link
Owner

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this, @badeend! Please see my comments below. None of them are blockers per se, but I think we'll need to address them eventually.

libc-bottom-half/cloudlibc/src/libc/sys/socket/__utils.c Outdated Show resolved Hide resolved
libc-bottom-half/cloudlibc/src/libc/sys/socket/__utils.c Show resolved Hide resolved
libc-bottom-half/cloudlibc/src/libc/sys/socket/accept.c Show resolved Hide resolved
libc-bottom-half/cloudlibc/src/libc/sys/socket/listen.c Show resolved Hide resolved
libc-bottom-half/cloudlibc/src/libc/sys/socket/recv.c Outdated Show resolved Hide resolved
libc-bottom-half/cloudlibc/src/libc/sys/socket/send.c Show resolved Hide resolved
libc-bottom-half/cloudlibc/src/libc/sys/socket/sockopt.c Show resolved Hide resolved
libc-bottom-half/cloudlibc/src/libc/sys/socket/sockopt.c Show resolved Hide resolved
libc-bottom-half/cloudlibc/src/libc/sys/socket/accept.c Show resolved Hide resolved
@dicej dicej self-requested a review December 4, 2023 19:45
dicej
dicej approved these changes Dec 4, 2023
View reviewed changes
Copy link
Owner

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to test this with the Rust project forks I've been working on (e.g. mio, tokio, tokio-postgres) to make sure there aren't any regressions, then I'll merge it.

Thanks again!

@dicej dicej merged commit 5af19d5 into dicej:sockets Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicej dicej dicej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badeend @dicej