Update deps to make it work on Node 18 #22
Conversation
There was a problem hiding this comment.
@dichovsky @EHadoux This looks good to me, just one minor comment is my suggested changes: it is preferable to pin non-dev dependencies to specific versions.
Co-authored-by: Allen Merlin Stern <sternam@users.noreply.github.com>
|
Hey, all done, although I don't think it's preferable at all. Not pinning canvas would have removed the need for this PR. Now we have |
There was a problem hiding this comment.
@dichovsky Could you please merge or give write ability to me or @EHadoux ? This is holding up my migration to Node v18
Hey, all done, although I don't think it's preferable at all. Not pinning canvas would have removed the need for this PR. Now we have
overridesin package.json so it's fine, but we don't benefit from the tests of this repo.
💯 Thanks @EHadoux! I think it is best practice what you're doing now: to pin to specific version for dependencies but use the ^ in devDependencies.
This PR fixes #20.
node-canvas has been released with pre-built binaries for Node 18, which was the last bit left to make it runnable on all platforms.