-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Annotation Inheritance, tests, and docs #654
Conversation
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
6076c7f
to
7a614ee
Compare
Couple of things we will need to think about with this when testing actually - the first is if the child class overrides something in the parent class we want to take the childs implementation not the parents
I would imagine some sort of key check in copyAnnotations should do the trick. Similarly (not sure why this would happen) but if we modify the annotation value on the child we want to make sure it doesn't update the parent (essentially we would want a deep copy)
|
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
…ld is updated Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Great catches. Impl updated as well as tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry couple more comments!
Signed-off-by: Brian Downs <brian.downs@gmail.com>
All set! |
Nicceeee thanks for this!! |
No prob. Thanks for the quick reviews! My ORM is really coming along now that all of the annotation features are in! |
Awesome! Definitely be interested to see it! Also side note, I ended up using Wanbli for a little side project of mine :) |
Open to any and all feedback on that. I don't really have it in a stable state yet so use with caution! |
It’s all good just a little tool I’m using in the house to track some smart plug usage! I’ll potentially PR some things across for it but it’s been a fun project |
Here's the ORM. Suuuuper naive... Not finished but works. https://github.com/briandowns/kahless . Gonna get an example together using Kahless and Wanbli together. |
This looks really cool! |
Resolves: #633
What's Changed:
Added the ability to have classes inherit class, method, and field annotations.
Type of Change:
Housekeeping:
Screenshots (If Applicable):