Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve to pre-load comments, we can now show comments without scrolling. #12

Merged
merged 3 commits into from
Dec 27, 2017

Conversation

1natsu172
Copy link
Collaborator

FIx Issue: #6

I changed the hide method. comments DOM element doesn't disappear.
The YouTube's comment loading script doesn't seem to catch fire unless the target DOM (e.target.tagName === 'YTD-ITEM-SECTION-RENDERER') is valid.
It is mean, comments is hide, but enabled in DOM.

please check regard.

@dideler
Copy link
Owner

dideler commented Dec 27, 2017

Tested locally and works great. This is very useful and I'm sure users will appreciate it as much as I do. Thank you very much for the patch, @1natsu172!

@dideler dideler merged commit acb3630 into dideler:master Dec 27, 2017
@1natsu172
Copy link
Collaborator Author

@dideler
Thanks merge this PR & release to chrome extension webstore! 🙏

@dideler
Copy link
Owner

dideler commented Dec 28, 2017

Released to the Chrome Web Store as v2.3.0 ✨

@1natsu172 1natsu172 deleted the PR/preLoad-comments branch February 3, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants