Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix problem: Anti-aliasing isn't applied to "SHOW COMMENTS" button. #30

Merged
merged 1 commit into from
Feb 3, 2018

Conversation

1natsu172
Copy link
Collaborator

Issue: #25

Add style the -webkit-font-smoothing: antialiased; . In this PR, font-weight is the same as "SHOW MORE" button. 👀

@dideler
Copy link
Owner

dideler commented Feb 3, 2018

Looks good 👍

@dideler dideler self-requested a review February 3, 2018 14:31
@1natsu172
Copy link
Collaborator Author

Thanks for your reviewed & approved 🙌
The other day you created a group publisher account. So this time I'll try deploying!

@1natsu172 1natsu172 merged commit 641716e into master Feb 3, 2018
@1natsu172 1natsu172 deleted the fix#25/showComments-antialiasing branch February 3, 2018 16:02
@1natsu172
Copy link
Collaborator Author

Question about versioning. I think that this time is a minor update. Because only the bug fix.
I'm trying to v2.5.1 (current: v2.5.0), so isn't it different from @dideler perception?

@dideler
Copy link
Owner

dideler commented Feb 3, 2018

@1natsu172 that's right, I would do a minor bump for this.

I would personally do two minor bumps (v2.5.1 for #29 and v2.5.2 for #30) to keep version updates granular and focused on a single API, feature, or patch change.

In this case because both PRs are merged, I would suggest creating two tags, but only one commit at the HEAD for the version change to v2.5.2. (Only one commit for the version bump because we don't want to rewrite master history to insert a version update in between the two merge commits.)

@dideler
Copy link
Owner

dideler commented Feb 3, 2018

@dideler
Copy link
Owner

dideler commented Feb 3, 2018

@1natsu172 I rewrote #30 (comment) because I found my original comment difficult to read - hope it's clearer now.

Also added a bit more info to the contributing guide and created #32 so we have a shared collection of images used historically on the Chrome Web Store. Since this visual change is minor, I personally don't think it'll be worth the effort to take and upload new screenshots, but it's up to you.

@1natsu172
Copy link
Collaborator Author

Thanks for the detailed reply and documentation preparation!

(Only one commit for the version bump because we don't want to rewrite master history to insert a version update in between the two merge commits.)

I was planning to insert a version between two commits using git rebase -i.
But you seem to don't want it, I'll correspond with two tags and one manifest.json update(to v2.5.2) this time. From next time I try to separate merge & update one by one. 🙇

1natsu172 added a commit that referenced this pull request Feb 4, 2018
Fixed the problem where anti-aliasing was not working on the button of show comments. Button to blend into YouTube's UI. #30
@1natsu172
Copy link
Collaborator Author

Bump version to v2.5.2 completed.
I already deployed at chrome web store. So, the extension will be updated with a little time.

@dideler
Copy link
Owner

dideler commented Feb 4, 2018

Congratulations for releasing and publishing the extension!

1natsu172 added a commit that referenced this pull request Feb 11, 2018
Fixed the problem where anti-aliasing was not working on the button of show comments. Button to blend into YouTube's UI. #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants