-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix problem: Anti-aliasing isn't applied to "SHOW COMMENTS" button. #30
Conversation
Add style the antialiased #25
Looks good 👍 |
Thanks for your reviewed & approved 🙌 |
Question about versioning. I think that this time is a minor update. Because only the bug fix. |
@1natsu172 that's right, I would do a minor bump for this. I would personally do two minor bumps (v2.5.1 for #29 and v2.5.2 for #30) to keep version updates granular and focused on a single API, feature, or patch change. In this case because both PRs are merged, I would suggest creating two tags, but only one commit at the HEAD for the version change to v2.5.2. (Only one commit for the version bump because we don't want to rewrite master history to insert a version update in between the two merge commits.) |
I've added a section on releasing to the contributing guide. |
@1natsu172 I rewrote #30 (comment) because I found my original comment difficult to read - hope it's clearer now. Also added a bit more info to the contributing guide and created #32 so we have a shared collection of images used historically on the Chrome Web Store. Since this visual change is minor, I personally don't think it'll be worth the effort to take and upload new screenshots, but it's up to you. |
Thanks for the detailed reply and documentation preparation!
I was planning to insert a version between two commits using |
Fixed the problem where anti-aliasing was not working on the button of show comments. Button to blend into YouTube's UI. #30
Bump version to v2.5.2 completed. |
Fixed the problem where anti-aliasing was not working on the button of show comments. Button to blend into YouTube's UI. #30
Issue: #25
Add style the
-webkit-font-smoothing: antialiased;
. In this PR, font-weight is the same as "SHOW MORE" button. 👀