Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swiper): refactor user scrolling judgment by touch angle #541

Merged
merged 3 commits into from
Sep 4, 2019

Conversation

xxyan0205
Copy link
Collaborator

背景描述

是否用户滚动页面行为的判断存在问题,无法区分touchmove轨迹“拐弯”的情况,会造成无法正常翻页#540

主要改动

重写$_isScroll方法,根据滚动夹角判断是否用户滚动页面行为

需要注意

是否阻塞正常滚动

@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #541 into dev will decrease coverage by 0.31%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #541      +/-   ##
==========================================
- Coverage   81.16%   80.84%   -0.32%     
==========================================
  Files          91       91              
  Lines        2723     2725       +2     
  Branches      522      526       +4     
==========================================
- Hits         2210     2203       -7     
- Misses        367      372       +5     
- Partials      146      150       +4
Impacted Files Coverage Δ
components/swiper/index.vue 64.57% <50%> (-2.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a99869...11b47a0. Read the comment docs.

@xxyan0205 xxyan0205 merged commit af40f5c into dev Sep 4, 2019
@xxyan0205 xxyan0205 deleted the fix_swiper_freeze branch September 17, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants