feat(core/types): add chaining derivation support to mapState & mapGetters #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add chaining derivation support to mapState & mapGetters
hiyuki
reviewed
Dec 16, 2020
hiyuki
reviewed
Dec 16, 2020
hiyuki
reviewed
Dec 16, 2020
fix createGettersWithThis's problem
|
新修复了一些问题，当使用createStoreWithThis创建store时，如果引入createStore创建的store会报错。此时采用老版本兼容方式处理。 |
anotherso1a
commented
Dec 24, 2020
packages/core/@types/mpx-store.d.ts
Outdated
Comment on lines
241
to
242
| dispatch(type: string, ...payload: any[]): any | ||
| commit(type: string, ...payload: any[]): any |
There was a problem hiding this comment.
这里这样写主要是因为使用dispatch: () => {}这种形式定义的方法在ts中无法在同一个对象里面进行重载。
报错： Duplicate identifier 'dispatch'.ts(2300)
如果想要重载现在看来只能采取这种迂回的方式。
|
优化了一下写法，后续如果统一使用createStoreWithThis之后可以直接出除去用于重载的interface |
|
关闭了对state、getters的对象本身层级的递归推导，避免由于过多过深的state或getter数据使ts推导瘫痪。 |
hiyuki
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix $forceUpdate's types