[Refactor]: 重构 render/pages 目录下三个文件, 使用 Vue3 组合式 API 写法 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwayrun
changed the title
sudoooooo
reviewed
May 15, 2024
| @@ -28,115 +30,101 @@ import encrypt from '../utils/encrypt' | |||
|
|
|||
There was a problem hiding this comment.
vscode校验提示：Module '"xiaoju-survey/web/src/render/components/ProgressBar.vue"' has no default export.Vetur
There was a problem hiding this comment.
这个应该是 vscode Vetur 插件导致的，我看我这边 vscode 没有这个校验提示
sudoooooo
reviewed
May 15, 2024
web/src/render/pages/IndexPage.vue
Outdated
| isMobile?: boolean, | ||
| } | ||
|
|
||
| const props = withDefaults(defineProps<Props>(), { |
There was a problem hiding this comment.
eslint校验提示：'props' is assigned a value but never used.eslint
alwayrun
force-pushed
the
refactor/render_pages
branch
from
abd091c
to
acd157b
Compare
sudoooooo
pushed a commit
that referenced
this pull request
May 15, 2024
skique
pushed a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改动内容
使用 Vue3 组合式 API 写法, 重构下例三个文件
render/pages/ErrorPage.vue
render/pages/IndexPage.vue
render/pages/SuccessPage.vue