Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复富文本编辑器上传图片 #410

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix: 修复富文本编辑器上传图片 #410

merged 2 commits into from
Sep 6, 2024

Conversation

webaddkevin
Copy link
Contributor

@webaddkevin webaddkevin commented Sep 2, 2024 •
edited
Loading

改动内容

  1. 修正前端题目TitleModule组件点击工具条上传图片触发关闭title编辑的bug

Issue

@nilnoop
Copy link
Contributor

nilnoop commented Sep 2, 2024

第2点，上传图片时如果使用oss等对象存储，url会返回为包含域名的绝对路径，这部分逻辑需要兼容一下。
另外url需要补齐服务端路径的场景是什么呢？ B\C端不在同一个服务器吗？

@webaddkevin
Copy link
Contributor Author

第2点，上传图片时如果使用oss等对象存储，url会返回为包含域名的绝对路径，这部分逻辑需要兼容一下。 另外url需要补齐服务端路径的场景是什么呢？ B\C端不在同一个服务器吗？

不好意思之前我改错了，标题插入图片有点问题其他是正确的

@sudoooooo
Copy link
Collaborator

image
操作图片工具条的时候会有问题

@webaddkevin
Copy link
Contributor Author

webaddkevin commented Sep 5, 2024 via email

@sudoooooo sudoooooo merged commit 43001a1 into didi:develop Sep 6, 2024
1 check passed
sudoooooo pushed a commit that referenced this pull request Sep 23, 2024
@webaddkevin @sudoooooo
fix: 修复富文本编辑器上传图片 (#410)
afbd636 
* fix: 修复题目标题插入图片异常问题

* fix: 修改事件监听顺序，避免编辑图片百分比时重新渲染工具条而找不到点击的dom

---------

Co-authored-by: jiangchunfu <jiangchunfu@kaike.la>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webaddkevin @nilnoop @sudoooooo