Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: 调整服务端环境变量导入机制 #43

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

alwayrun
Copy link
Contributor

1、为环境变量 process.env 增加 TypeScript 类型检测与感知
2、增加 dotenv & @types/node 处理支持 .env文件环境变量导入机制

Copy link
Collaborator

@sudoooooo sudoooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请合并成一个commit

@alwayrun
Copy link
Contributor Author

@sudoooooo 已合并成一个 commit

@sudoooooo
Copy link
Collaborator

@alwayrun 改动经过验证服务侧有问题,初步查看npm run local无法连接DB。请验证无误后提交。

@@ -21,10 +21,6 @@ services:
restart: always
ports:
- "8080:3000" # API端口
environment:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除的原因是什么呢?

Copy link
Contributor Author

@alwayrun alwayrun Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方环境变量信息都放到 .env 文件了,所以不需要通过这个地方带入环境变量信息

1、为环境变量 process.env 增加 TypeScript 类型检测与感知
2、增加 dotenv & @types/node 处理支持 .env文件环境变量导入机制
@alwayrun
Copy link
Contributor Author

@alwayrun 改动经过验证服务侧有问题,初步查看npm run local无法连接DB。请验证无误后提交。

@sudoooooo 已调整, 本地 local & dev 都有跑过,没有问题了,你再试试

@sudoooooo sudoooooo merged commit 642f4f0 into didi:develop Jan 16, 2024
sudoooooo pushed a commit that referenced this pull request Jan 17, 2024
1、为环境变量 process.env 增加 TypeScript 类型检测与感知
2、增加 dotenv & @types/node 处理支持 .env文件环境变量导入机制
@sudoooooo sudoooooo mentioned this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants