Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S*ELTD vs SELTD for "settled" #28

Closed
paulfioravanti opened this issue Dec 23, 2018 · 3 comments
Closed

S*ELTD vs SELTD for "settled" #28

paulfioravanti opened this issue Dec 23, 2018 · 3 comments

Comments

@paulfioravanti
Copy link
Contributor

The stroke entry for the word "settled" in Plover and Typey Type is S*ELTD. The word "settled" can also be stroked more easily without the asterisk as SELTD (which I found out by accident).

However, there is no specified entry for this stroke in any dictionary in Typey Type or Plover. Is there a reason for this that you can think of? If not, would this entry be worth adding to the Typey Type dictionaries as an improvement on the Plover entry?

didoesdigital added a commit that referenced this issue Dec 25, 2018
"SELTD": "settled", "SELTG": "settling", and "SELTS": "settles", can all
be written without explicit entries using Plover’s orthography rules. We
add explicit entries to condensed strokes to improve Typey Type
suggestions and improve brief look ups.

Fixes #28
@didoesdigital
Copy link
Owner

@paulfioravanti It looks like SELTD is using Plover's suffix keys, Plover's orthography English rules, and Plover's orthography translation.

The suffix key -D will automatically append "ed" using "-D": "{^ed}", when tucked into an existing entry. Given the entry, "SELT": "settle", I would expect adding "D" to produce something like settle{^ed}.

Then, using Plover's orthography rules, the second "e" is removed to give us "settled" as intended.

I've added some explicit entries for settled, settling, and settles to improve look ups in Typey Type.

Generally I try to limit the condensed-strokes.json dictionary to entries that work from a combination of existing entries like "TEFT" and "TEFT/-G" where "TEFT" exactly matches "test" and "-G" is "ing". In this case, "settled" depends on the orthography rules for English and couldn't work by strokes alone. I think this is near enough though.

@didoesdigital
Copy link
Owner

Thanks for highlighting this @paulfioravanti. Please let me know if any of that doesn't make sense.

@paulfioravanti
Copy link
Contributor Author

Thanks for the detailed explanation, @didoesdigital. That helps a lot!

didoesdigital added a commit that referenced this issue Apr 18, 2020
… in Top 10000 Project Gutenberg words, using orthography rules

#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants