Task manager - clone without recursion #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With latest GVL updates the
clone
method ofCloneable
abstract class that using recursion stops working due to call stack limit even withError.stackTraceLimit = Infinity
.The solution could be to introduce an alternative approach to deep clone of the object using tasks.
This PR implements
TaskManager
class that clones the object without the recursion usingTask
objects andTaskQueue
class.The
run
method of theTaskManager
creates a new root task for given object and callprocessor
method. This methods is running processing loop: reads next task fromTaskQueue.toDo
process it usingtaskProcessor
(refactoring copy of theCloneable.clone
) function and move task to the next state:Done
orBlocked
. If task data object is complex value thetaskProcessor
will create a number of subtasks and put them in the queue for processing.After all tasks are processed and
TaskQueue.toDo
is empty thepostProcessor
method will work withTaskQueue.done
to merge subtasks to parent task and update the parent task status status if needed. If the root task status is set toDone
thepostProcessor
is finished and the root task data will be returned as result.