🧑‍💻 Add some Init Containers #1319

rblaine95 · 2025-02-08T10:21:53Z

Add some Init Containers to make sure Postgres is up
- Governance/Multitenant Agent
- Mediator
- Trust Registry
- Reduces pod restarts due to PG not being up
Trust Registry doesn't have the Askar bug when using PGPool
- That bug where if the DB doesn't exist it can't connect to a connection pooler
- Trust Registry doesn't create it's own DB, so it can always use PGPool
NATS does not depend on Istio
- Could very slightly speed up local startup

helm/acapy-cloud/conf/dev/trust-registry.yaml

helm/acapy-cloud/conf/local/trust-registry.yaml

* Add some Init Containers to make sure Postgres is up * Governance/Multitenant Agent * Mediator * Trust Registry * NATS does not depend on Istio

github-actions · 2025-02-08T11:10:57Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4960	547	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	0 ❌	0 🔥	4m 27s ⏱️

github-actions · 2025-02-08T11:10:57Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4960	597	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	0 ❌	0 🔥	3m 51s ⏱️

sonarqubecloud · 2025-02-08T11:16:14Z

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-02-08T11:20:57Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4960	547	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	0 ❌	0 🔥	4m 26s ⏱️

github-actions · 2025-02-08T11:20:58Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4960	597	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	0 ❌	0 🔥	3m 54s ⏱️

github-actions · 2025-02-08T11:30:52Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	12	81%	111–112, 125–141, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
save_exchange_record.py	13	1	92%	29
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	34–35
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4960	547	89%

Tests	Skipped	Failures	Errors	Time
895	6 💤	0 ❌	0 🔥	4m 40s ⏱️

github-actions · 2025-02-08T11:30:53Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	80	2	98%	121–122
app/models
wallet.py	36	4	89%	100–105
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	80	53	34%	57–70, 96–108, 129–140, 166–180, 216–232, 266–283, 309–321, 342–353
app/services
acapy_ledger.py	63	19	70%	44–50, 80, 111–112, 125–141, 147–150, 200–201
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	97	12	88%	63, 97–106, 110, 126–127, 172, 225–226, 252
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	95	5	95%	100–102, 276–281
set_endorser_metadata.py	72	40	44%	32–34, 58–60, 85–87, 118–137, 149–160, 172–185, 198–212
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
save_exchange_record.py	13	1	92%	29
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	21–39
shared
log_config.py	53	20	62%	41–94, 103–110, 152, 161–173
shared/models
connection_record.py	24	1	96%	47
credential_exchange.py	43	7	84%	85–88, 101–104
endorsement.py	86	69	20%	36–70, 92–122, 132–181
presentation_exchange.py	40	9	78%	54–56, 62–64, 82, 87, 91
protocol.py	10	1	90%	18
trustregistry.py	63	7	89%	22, 44, 75–83
shared/services
nats_jetstream.py	36	4	89%	56, 60, 64, 68
shared/util
api_router.py	14	1	93%	17
mock_agent_controller.py	55	6	89%	23, 74–78
trustregistry
main.py	84	4	95%	49–51, 113
waypoint
main.py	50	1	98%	67
waypoint/services
nats_service.py	112	3	97%	73–75
TOTAL	4960	597	88%

Tests	Skipped	Failures	Errors	Time
895	46 💤	0 ❌	0 🔥	3m 54s ⏱️

rblaine95 self-assigned this Feb 8, 2025

github-advanced-security bot found potential problems Feb 8, 2025

View reviewed changes

helm/acapy-cloud/conf/dev/trust-registry.yaml Fixed Show fixed Hide fixed

helm/acapy-cloud/conf/local/trust-registry.yaml Fixed Show fixed Hide fixed

rblaine95 force-pushed the chore/init-containers branch from baf4eb4 to fb5c459 Compare February 8, 2025 10:39

🧑‍💻 Add some Init Containers

a229cc7

* Add some Init Containers to make sure Postgres is up * Governance/Multitenant Agent * Mediator * Trust Registry * NATS does not depend on Istio

rblaine95 force-pushed the chore/init-containers branch from fb5c459 to a229cc7 Compare February 8, 2025 10:49

rblaine95 marked this pull request as ready for review February 8, 2025 11:00

rblaine95 temporarily deployed to dev February 8, 2025 11:01 — with GitHub Actions Inactive

rblaine95 had a problem deploying to dev February 8, 2025 11:08 — with GitHub Actions Error

rblaine95 force-pushed the chore/init-containers branch from 8daa1db to 59fb4f8 Compare February 8, 2025 11:08

rblaine95 temporarily deployed to dev February 8, 2025 11:10 — with GitHub Actions Inactive

📈 Bump DD Python Lib 2.20.0 -> 2.20.1

e8dda12

rblaine95 force-pushed the chore/init-containers branch from 59fb4f8 to e8dda12 Compare February 8, 2025 11:14

rblaine95 deployed to dev February 8, 2025 11:16 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🧑‍💻 Add some Init Containers #1319

🧑‍💻 Add some Init Containers #1319

rblaine95 commented Feb 8, 2025 •

edited

Loading

github-actions bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

sonarqubecloud bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

🧑‍💻 Add some Init Containers #1319

Are you sure you want to change the base?

🧑‍💻 Add some Init Containers #1319

Conversation

rblaine95 commented Feb 8, 2025 • edited Loading

github-actions bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

sonarqubecloud bot commented Feb 8, 2025

Quality Gate passed

github-actions bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

github-actions bot commented Feb 8, 2025

rblaine95 commented Feb 8, 2025 •

edited

Loading