-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ ✨ Upgrade acapy 1.0.0 #990
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great stuff! Just a couple important changes (avoid potential KeyError; and should we endorse a list of transaction ids now?), and some nitpicks: log levels and type hints
cls, values: TxnOrPublishRevocationsResult | ||
) -> Dict[str, Any]: | ||
if isinstance(values, dict) and "txn" in values: | ||
txn_list: List[TransactionRecord] = values.get("txn") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor note: this isn't actually a List[TransactionRecord]. It's a List[Dict[str,Any]], which has same shape as List[TransactionRecord]. Point being that the pydantic model doesn't have a .get method. So the type hint makes it seem like txn.get
will error. So, for clarity we can just set the type hint to list of dict, and comment that it's list transactionrecord
Enrich revoked responses
NB:
/revoke
endpoint no longer returns empty success (204), and instead gives RevokedResponseUpgrade to Aca-Py v1.0.0