Windowing histogram #298
Merged
Windowing histogram #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6b39071.
Histogram updates to selected slice. In 3D view, it syncs to the Axial view. The seperate views cannot support their own windowing sliders until the way windowing is handled is changed to accomodate individual slice windowing.
sjswerdloff
approved these changes
Oct 21, 2023
| slices = len(self.pixel_values) | ||
| self.densities = [[]] * slices | ||
| for s in range(slices): | ||
| self.densities[s] = [0] * WindowingSlider.MAX_PIXEL_VALUE |
There was a problem hiding this comment.
so your histogram has MAX_PIXEL_VALUE bins?
|
|
||
| # Normalise values | ||
| for i in range(WindowingSlider.MAX_PIXEL_VALUE): | ||
| self.densities[s][i] = self.densities[s][i] / max_value * 10000 |
There was a problem hiding this comment.
10000 is a magic number. prefer refactor to constant or variable with meaningful name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3D view, it syncs to the Axial view.
The seperate views cannot support their own windowing sliders until the way windowing is handled is changed to accomodate individual slice windowing.