Make PID row input component React-controlled to better fix #292 and #293 #301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#298 and #299 were merged to fix #292 and #293. But they seem a bit hacky to me.
Making the
input
component React-controlled, by passing the state variablevalue
as itsvalue
prop, seems to solve both #292 and #293 in a simpler and more React-y way.Remember this
input
component was introduced to replace anEditable
component around 973e924 until we found a way to import Zotero components. See f1792e7#r146509552