Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PID row input component React-controlled to better fix #292 and #293 #301

Closed
wants to merge 2 commits into from

Conversation

diegodlh
Copy link
Owner

#298 and #299 were merged to fix #292 and #293. But they seem a bit hacky to me.

Making the input component React-controlled, by passing the state variable value as its value prop, seems to solve both #292 and #293 in a simpler and more React-y way.

Remember this input component was introduced to replace an Editable component around 973e924 until we found a way to import Zotero components. See f1792e7#r146509552

@Dominic-DallOsto
Copy link
Collaborator

I quickly tested this and it seems to work well in the main Zotero pane, but in the citation editor I get the following bug:

  1. Open the citation editor for a cited item with a DOI and a QID
  2. Delete the QID
  3. Press save, then open the citation editor again
  4. Now fetch the QID, the progress popup will say it was successful but the pid row text box doesn't update
  5. Press save, close, then reopen the citation editor
  6. The QID is displayed

@Dominic-DallOsto
Copy link
Collaborator

This should have been fixed by #300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants