Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and clean up translations for Zotero 7 #308

Draft
wants to merge 1 commit into
base: zotero7
Choose a base branch
from
Draft

Fix and clean up translations for Zotero 7 #308

wants to merge 1 commit into from

Conversation

thebluepotato
Copy link

In an attempt to complete the 4 remaining tasks of #257, I'd like to address at least #288 and #289 here, and the issues with the citation editor. Still a WIP

@thebluepotato thebluepotato marked this pull request as draft November 22, 2024 09:56
@thebluepotato
Copy link
Author

For the this.delayConnectedCallback is not a function error, the issue seems to be that the menupopup created when clicking the button within the citation editor is a generic XULPopupElement whereas when the same button is clicked in the item box, it's a MozMenuPopup. Still investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thebluepotato