Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixtures, and test for Link component with package json #8

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

dmitrika
Copy link
Contributor

@dmitrika dmitrika commented Jun 26, 2017

Closes #4
It works, but if we do not specify second attribute componentName for getFiles function, is that ok?

@dmitrika
Copy link
Contributor Author

Huh, locally I have all test passed.
Seems, like travis has different setup.

I added fixtures by git clone repo in the fixtures dir, is that correct way?

@diegohaz
Copy link
Owner

@dmitrika I think you need to rm -rf .git inside test/fixtures/react-static-boilerplate. Otherwise it will be read as a git submodule.

@codecov-io
Copy link

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #8   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          31     31           
  Branches        4      4           
=====================================
  Hits           31     31
Impacted Files Coverage Δ
src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56beefa...f5f1957. Read the comment docs.

@dmitrika
Copy link
Contributor Author

Yeap, looks like it helped!

I didn't know it before, btw 🤓

@diegohaz
Copy link
Owner

Nice. Thank you, @dmitrika 😊

@diegohaz diegohaz merged commit a581f81 into diegohaz:master Jun 26, 2017
@dmitrika
Copy link
Contributor Author

Thank you for excellent support!

@dmitrika dmitrika deleted the copy-json-files branch June 26, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants