chore: make cx and cy optional in Circle and Ellipse (#2314)

diegomura · May 31, 2023 · d6018d5 · d6018d5
1 parent dfb46c1
commit d6018d5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/.changeset/warm-needles-cough.md b/.changeset/warm-needles-cough.md
@@ -0,0 +1,6 @@
+---
+'@react-pdf/renderer': patch
+'@react-pdf/render': patch
+---
+
+Make `cx` and `cy` optional in `Circle` and `Ellipse`
diff --git a/packages/render/src/primitives/renderEllipse.js b/packages/render/src/primitives/renderEllipse.js
@@ -1,6 +1,6 @@
 const KAPPA = 4.0 * ((Math.sqrt(2) - 1.0) / 3.0);
 
-export const drawEllipse = (ctx, cx, cy, rx, ry) => {
+export const drawEllipse = (ctx, cx = 0, cy = 0, rx, ry) => {
   const x = cx - rx;
   const y = cy - ry;
   const ox = rx * KAPPA;

diff --git a/packages/renderer/index.d.ts b/packages/renderer/index.d.ts
@@ -32,7 +32,7 @@ declare namespace ReactPDF {
     language?: string;
     pdfVersion?: PDFVersion;
     pageMode?: PageMode;
-    pageLayout ?: PageLayout;
+    pageLayout?: PageLayout;
     onRender?: (props: OnRenderProps) => any;
   }
 
@@ -318,8 +318,8 @@ declare namespace ReactPDF {
 
   interface CircleProps extends SVGPresentationAttributes {
     style?: SVGPresentationAttributes;
-    cx: string | number;
-    cy: string | number;
+    cx?: string | number;
+    cy?: string | number;
     r: string | number;
   }
 
@@ -330,8 +330,8 @@ declare namespace ReactPDF {
 
   interface EllipseProps extends SVGPresentationAttributes {
     style?: SVGPresentationAttributes;
-    cx: string | number;
-    cy: string | number;
+    cx?: string | number;
+    cy?: string | number;
     rx: string | number;
     ry: string | number;
   }