-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji not rendering correctly depending on emoji-source #2466
Comments
JaeSeoKim
added a commit
to JaeSeoKim/react-pdf
that referenced
this issue
Dec 20, 2023
diegomura
pushed a commit
that referenced
this issue
Jan 14, 2024
* feat: add withVariationSelectors option to registerEmojiSource fixed: #2466 * feat: update EmojiSource * chore: create changeset
mskec
pushed a commit
to mskec/react-pdf
that referenced
this issue
Feb 26, 2024
…mura#2467) * feat: add withVariationSelectors option to registerEmojiSource fixed: diegomura#2466 * feat: update EmojiSource * chore: create changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Variation Selectors (U+FE00..U+FE0F) were required depending on the emoji-source, causing emoji to not render correctly.
To Reproduce
example with twemoji
example with npm:emoji-datasource
Expected behavior
Since the Variation Selectors are being removed via the
_removeNoColor
function, we need to get additional options for the conditions under which the filter works.for example
Screenshots
Error screenshot
fixed with a simple patch Screenshot
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: