-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add changesets #1581
Conversation
@jeetiss can you explain the motivation of this? Isn't Lerna do some of this stuff already? |
@diegomura sure.
|
.github/workflows/release.yml
Outdated
version: yarn version-packages | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diegomura could you add NPM_TOKEN
to github secrets? it should be an automation token that github announced couple days ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GITHUB_TOKEN
is provided on default, so you don't need to add it.
@diegomura i add some explanation to PR description
yes, changesets is inspired by lerna but improves all aspects of release. last thing. I tried to automate all possible things, so if you want to run some steps manually, just say and i prepare it here 😄 |
* remove build from release command because it builds while install
6845dcb
to
9200329
Compare
@jeetiss thanks for merging this and improving the release cycle. And also for all the hard work you are putting on the project. I'll try to be more responsive and present than I've been for the last weeks. Can you quickly explain how this changes how to publish a new version? I'm not sure I grasped 100% of wht |
@diegomura hooray 🙌🏻 I am almost ready with the new release, I'm going to finish [this fix] (#1659) today, and after we can release changesetsI can't explain it better than changesets maintainers do, so read this article here are the changesets of all PRs that I merged changeset's github action generates a PR with generated changelogs and bumped versions for all packages, based on these files, you can check PR here I have finished the setup, but you need to add |
I kept reading about it and things make much sense now. Thanks! Just added the token. Does that token allows changelogs to publish any package under my name? How is it that releases through GH will work? |
thanks, it works ✨
Yes, it can release all packages placed in this repository under your name.
it should work like a magic ✨ when I merge PR all changeset files will be removed and release github action run |
release automation with changesets
changesets
provides an automated monopackage release flow with a review.here are steps from PR to release:
patch
,minor
,major
) like thisLerna has a similar release flow with semantic releases, but changeset is better because:
TODOs