Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deduplicate scheduler #1605

Merged
merged 3 commits into from
Dec 18, 2021
Merged

fix: deduplicate scheduler #1605

merged 3 commits into from
Dec 18, 2021

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented Nov 21, 2021

@react-pdf/renderer uses scheduler@0.15.0
react-reconciler@0.23.0 uses scheduler@0.17.0

as result we have two scheduler instances in bundle
Снимок экрана 2021-11-21 в 14 11 02

pr fix this

@jeetiss jeetiss requested a review from diegomura November 21, 2021 12:05
@jeetiss jeetiss self-assigned this Nov 21, 2021
@jeetiss jeetiss merged commit e7a93bc into master Dec 18, 2021
@jeetiss jeetiss deleted the dedupe-sheduler branch December 18, 2021 13:26
@github-actions github-actions bot mentioned this pull request Dec 18, 2021
Merged
This was referenced Dec 28, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomura diegomura Awaiting requested review from diegomura

Assignees

@jeetiss jeetiss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeetiss