Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define renderToStream to return promise #1681

Merged

Conversation

dschu-lab
Copy link
Contributor

The old return type was string which is wrong, because it returns a promise which resolves in a string instead.

This pull request fixes the warning 'await' has no effect on the type of this expression when using it like this:

    const document = await ReactPDF.renderToString(...)

dschu-lab and others added 2 commits January 19, 2022 12:37
The old return type was `string` which is wrong, because it returns a `promise` which resolves in a `string` instead.
@jeetiss jeetiss merged commit 4eddbf5 into diegomura:master Jan 26, 2022
@jeetiss
Copy link
Collaborator

jeetiss commented Jan 26, 2022

@dschu-lab thanks for your contribution! 🙌🏻

@github-actions github-actions bot mentioned this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants