refactor: remove ramda from render #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomura
force-pushed
the
dm/remove-ramda-from-render
branch
2 times, most recently
from
3acb5a2 to
80ab6a6
Compare
diegomura
force-pushed
the
dm/remove-ramda-from-render
branch
from
80ab6a6 to
afb2ffc
Compare
kidroca
reviewed
Aug 9, 2023
Comment on lines
+173
to
+179
| const renderFn = renderFns[node.type]; | ||
|
|
||
| if (renderFns) { | ||
| renderFn(ctx, node); | ||
| } else { | ||
| console.warn(`SVG node of type ${node.type} is not currenty supported`); | ||
| } |
There was a problem hiding this comment.
Hello,
I was going through the code and I noticed a small potential oversight. It seems that the condition if (renderFns) would always evaluate to true given the nature of JavaScript's truthy/falsy evaluation. I believe it might have been intended to be if (renderFn) to check for the existence of the specific render function:
const renderFn = renderFns[node.type];
if (renderFn) {
renderFn(ctx, node);
} else {
console.warn(`SVG node of type ${node.type} is not currently supported`);
}Thank you for all your hard work on this repository. I hope this helps!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gradually start removing ramda. Although I like it, it's probably confusing for most people, it's slow and adds unneccesary bundle size. Some helper fns will still be needed. For the moment I moved them to utils dir, in the future it worths building our own set of light and reusable utils