feat: add onClick event to PDFDownloadLink #1902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on request #975 and our own experience, having an
onClick
handler to invoke forPDFDownloadLink
would be benficial. E.g. We'd like to send a custom event to our analytics on download. (We're finding other means to lazily load the heavier components, so wouldn't need to resort to the workaround for this feature proposed there.)This implementation refactors the existing
onClick
handler slightly, to also allow consumer's to provide a function via props. We conditionally call this function after existinghandleDownloadIE
. (We'd generally opt foronClick?.()
, but as this package targets Node v12, we'll checktypeof
before invoking.)I've included the
event
as the first function argument, should the consumer need to use native event properties. That seems like the expected behaviour. Secondly, we pass along theinstance
, which might be helpful in certain circumstances. If that's not a beneficial use-case, would gladly omit.Added types. Not sure that this component has unit tests, but happy to add if need be.
Fixes #975