Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CJS compatibility in @react-pdf/pdfkit #2610

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix: CJS compatibility in @react-pdf/pdfkit #2610

merged 1 commit into from
Feb 6, 2024

Conversation

wojtekmaj
Copy link
Contributor

Missed that one in #2607!

Closes #2608

Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: b0a41d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@react-pdf/pdfkit Patch
@react-pdf/layout Patch
@react-pdf/renderer Patch
@react-pdf/svgkit Patch
@react-pdf/examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Thanks!

@diegomura diegomura merged commit dc54c13 into diegomura:master Feb 6, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
@wojtekmaj wojtekmaj deleted the cjs branch February 7, 2024 08:02
mskec pushed a commit to mskec/react-pdf that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: PNG is not a constructor - Can't generate pdf with a PNG in the document
2 participants