Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background image #2906

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

naresh-tts
Copy link

No description provided.

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 1aeb6b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

// import { createCanvas, loadImage } from "canvas";
import { Canvas, loadImage, Image } from "skia-canvas";

class NinePatch {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what is this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomura I have created background image with ninepatch that automatically create background canvas with shadow for background image we have to just pass image for that and it look lile below.
image
image
image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. That looks nice. But why is it related to background image? Isn't that more like box shadow? I'm a bit confused in that sense

Copy link
Author

@naresh-tts naresh-tts Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomura Yes that is box shadow but we have create image look like box shadow and provide that image as background so that's why it's related to background image.

"cross-fetch": "^3.1.5",
"emoji-regex": "^10.3.0",
"queue": "^6.0.1",
"skia-canvas": "https://github.com/samizdatco/skia-canvas/releases/download/v1.0.1/skia-canvas-v1.0.1-linux-x64-glibc.tar.gz",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this on npm?

Copy link
Author

@naresh-tts naresh-tts Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomura Before it available on npm but latest version is still not available on npm and it's recommendation to use this version from github once it available in npm we will update to get from npm.

Here is release link and deprication warning for not use via npm
https://github.com/samizdatco/skia-canvas/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants