icons_and_splashscreens.js hook bug on Windows #89
Comments
|
@marob Thank you so much for discovering this issue. I don't have easy access to a Windows machine, so can you please verify this issue has been resolved in version Much appreciated! |
|
@diegonetto Yes, it fixes the issue. Thanks. |
sidneys
added a commit
to sidneys/generator-ionic
that referenced
this issue
Aug 26, 2014
* commit 'e5cda9845789c71845694ad19d6782a7f185be93': docs(changelog): Update CHANGELOG 0.5.3 fix(hook): Change cordovaFile.split() paramater. Closes diegonetto#89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
in icons_and_splashscreens.js, the code
is buggy on Windows.
By using path.sep, you assume that cordovaFile has OS-dependent separators but that is not the case: the separator in the files returned by "glob" are "/" even on Windows.
As a result, because path.sep="" on Windows, the split method fails to do the job.
I think you should then replace the previous code by:
Regards
The text was updated successfully, but these errors were encountered: